Add auto-layer-releases flow to deploy flow #1274
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 79.68% 79.61% -0.08%
==========================================
Files 201 201
Lines 22174 22174
Branches 3519 3519
==========================================
- Hits 17669 17653 -16
- Misses 3355 3362 +7
- Partials 1150 1159 +9 ☔ View full report in Codecov by Sentry. |
.github/scripts/releases.py
Outdated
| @@ -0,0 +1,70 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
| #!/bin/bash | |
| #!/usr/bin/env python3 |
.github/scripts/releases.py
Outdated
| # How to use this script: | ||
| # Set the following env vars: | ||
| # * GH_RELEASE_TOKEN | ||
| # * LAMBDA_RUNTIME (optional) | ||
| # * INITCONTAINER_RUNTIME (optional) | ||
| # * AGENT_VERSION | ||
| # * DRY_RUN (optional) set to 1 to run the flow without creating the release tag. | ||
| # | ||
| # Lambda runtime options: | ||
| # nodejs | ||
| # python | ||
| # ruby | ||
| # dotnet | ||
| # | ||
| # Initcontainer runtime options: | ||
| # nodejs | ||
| # python | ||
| # ruby | ||
| # java | ||
| # dotnet |
There was a problem hiding this comment.
Why don't you make those a constant, so we don't have to set those as env vars? Presumably each repo will have a separate copy of this script.
There was a problem hiding this comment.
Well...I was still thinking of making it shared at this point (even though I realize I haven't done that in this PR). I guess TBD on that.
.github/scripts/releases.py
Outdated
| tag_name = f"{latest_version}.0_{runtime}" | ||
| release_name = f"New Relic {runtime} Agent {latest_version}.0" |
There was a problem hiding this comment.
This originally had logic to have release names and release tags as different strings. For Python the only difference was capitalization, but for Node and .NET it was Node -> nodejs, and .NET -> dotnet.
Why not make constants for TAG_SUFFIX="python" and RUNTIME_NAME="Python". Then maybe use bool constants to toggle on/off the lambda and initcontainer releases?
There was a problem hiding this comment.
oooh you're totally right! I was trying to simplify those out but they were used for the release name-I'll put those back I guess. Instead of a boolean I was thinking each team could just set the value of those and that way the work flow could be shared across all teams-I need to look into that more though to see if we can do that.
|
As a general thought, is there a reason not to convert this to bash scripting and use the |
I was actually thinking about this after I pushed this up as a Python script. Since we seem to both have had that thought, I'll just go ahead and do that. I agree-it would be easier to maintain that way for each team in the long run. |
hmstepanek
force-pushed
the
add-layers-release-flow-to-gha
branch
from
ad59deb to
30b2816
Compare
Move auto-layer-releases flow from lambda to GHA.
hmstepanek
force-pushed
the
add-layers-release-flow-to-gha
branch
from
690b061 to
9ac223d
Compare
.github/workflows/deploy-python.yml
Outdated
| @@ -182,3 +182,16 @@ jobs: | |||
| env: | |||
| TWINE_USERNAME: __token__ | |||
| TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }} | |||
|
|
|||
| - name: Create release tags for Lambda and K8s Init Containers | |||
| uses: dev-hanz-ops/install-gh-cli-action@c78dbed4be2f8d6133a14a9a597ee12fd4ed5c93 # v3 | |||
There was a problem hiding this comment.
gh should be preinstalled on all runners, I think this 3rd party action is unnecessary.
Co-authored-by: Timothy Pansino <[email protected]>
|
We've still got unrelated test issues to fix before we can merge this to main. |
Overview
Move auto-layer-releases flow from lambda to GHA.